henry
/
AccessQueueService
1
0
Fork 0
Code Issues 7 Pull Requests Packages Projects Releases Wiki Activity

added missing constant, removed superfluous comments

This commit is contained in:
henry 2025-05-08 21:39:10 -04:00
parent 6c9da8e796
commit 876d7e8b58
1 changed files with 5 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
AccessQueueServiceTests/AccessServiceTests.cs
View File

@ -30,7 +30,7 @@ namespace AccessQueueServiceTests
}; };
var configuration = new ConfigurationBuilder() var configuration = new ConfigurationBuilder()
.AddInMemoryCollection(inMemorySettings) // Add in-memory settings .AddInMemoryCollection(inMemorySettings)
.Build(); .Build();
_accessService = new AccessService(configuration); _accessService = new AccessService(configuration);
@ -39,13 +39,10 @@ namespace AccessQueueServiceTests
[Fact] [Fact]
public async Task RequestAccess_ShouldGrantAccess_WhenCapacityIsAvailable() public async Task RequestAccess_ShouldGrantAccess_WhenCapacityIsAvailable()
{ {
// Arrange
var userId = Guid.NewGuid(); var userId = Guid.NewGuid();
// Act
var response = await _accessService.RequestAccess(userId); var response = await _accessService.RequestAccess(userId);
// Assert
Assert.NotNull(response); Assert.NotNull(response);
Assert.NotNull(response.ExpiresOn); Assert.NotNull(response.ExpiresOn);
Assert.True(response.RequestsAhead == 0); Assert.True(response.RequestsAhead == 0);
@ -57,14 +54,11 @@ namespace AccessQueueServiceTests
[Fact] [Fact]
public async Task RequestAccess_ShouldReturnAccessResponse_WhenUserAlreadyHasTicket() public async Task RequestAccess_ShouldReturnAccessResponse_WhenUserAlreadyHasTicket()
{ {
// Arrange
var userId = Guid.NewGuid(); var userId = Guid.NewGuid();
await _accessService.RequestAccess(userId); // First request to create a ticket await _accessService.RequestAccess(userId);
// Act var response = await _accessService.RequestAccess(userId);
var response = await _accessService.RequestAccess(userId); // Second request for the same user
// Assert
Assert.NotNull(response); Assert.NotNull(response);
Assert.NotNull(response.ExpiresOn); Assert.NotNull(response.ExpiresOn);
Assert.True(response.RequestsAhead == 0); Assert.True(response.RequestsAhead == 0);
@ -76,20 +70,17 @@ namespace AccessQueueServiceTests
[Fact] [Fact]
public async Task RequestAccess_ShouldQueueUser_WhenCapacityIsFull() public async Task RequestAccess_ShouldQueueUser_WhenCapacityIsFull()
{ {
// Arrange
for (int i = 0; i < CAP_LIMIT * 2; i++) // Fill double capacity for (int i = 0; i < CAP_LIMIT * 2; i++) // Fill double capacity
{ {
await _accessService.RequestAccess(Guid.NewGuid()); await _accessService.RequestAccess(Guid.NewGuid());
} }
var userId = Guid.NewGuid(); var userId = Guid.NewGuid();
// Act
var response = await _accessService.RequestAccess(userId); var response = await _accessService.RequestAccess(userId);
// Assert
Assert.NotNull(response); Assert.NotNull(response);
Assert.Null(response.ExpiresOn); Assert.Null(response.ExpiresOn);
Assert.True(response.RequestsAhead == 5); Assert.True(response.RequestsAhead == CAP_LIMIT);
Assert.Equal(5, _accessService.UnexpiredTicketsCount); Assert.Equal(5, _accessService.UnexpiredTicketsCount);
Assert.Equal(5, _accessService.ActiveTicketsCount); Assert.Equal(5, _accessService.ActiveTicketsCount);
Assert.Equal(6, _accessService.QueueCount); Assert.Equal(6, _accessService.QueueCount);
@ -99,27 +90,21 @@ namespace AccessQueueServiceTests
[Fact] [Fact]
public async Task RevokeAccess_ShouldReturnTrue_WhenUserHasAccess() public async Task RevokeAccess_ShouldReturnTrue_WhenUserHasAccess()
{ {
// Arrange
var userId = Guid.NewGuid(); var userId = Guid.NewGuid();
await _accessService.RequestAccess(userId); await _accessService.RequestAccess(userId);
// Act
var result = await _accessService.RevokeAccess(userId); var result = await _accessService.RevokeAccess(userId);
// Assert
Assert.True(result); Assert.True(result);
} }
[Fact] [Fact]
public async Task RevokeAccess_ShouldReturnFalse_WhenUserDoesNotHaveAccess() public async Task RevokeAccess_ShouldReturnFalse_WhenUserDoesNotHaveAccess()
{ {
// Arrange
var userId = Guid.NewGuid(); var userId = Guid.NewGuid();
// Act
var result = await _accessService.RevokeAccess(userId); var result = await _accessService.RevokeAccess(userId);
// Assert
Assert.False(result); Assert.False(result);
} }
@ -230,7 +215,7 @@ namespace AccessQueueServiceTests
public async Task RequestAccess_ShouldReportLessInQueue_AsTicketsInactivate() public async Task RequestAccess_ShouldReportLessInQueue_AsTicketsInactivate()
{ {
var start = DateTime.UtcNow; var start = DateTime.UtcNow;
for (int i = 0; i < CAP_LIMIT; i++) // Fill all slots for (int i = 0; i < CAP_LIMIT; i++)
{ {
var elapsed = DateTime.UtcNow - start; var elapsed = DateTime.UtcNow - start;
Console.WriteLine($"Elapsed time: {elapsed.TotalSeconds} s: Adding {i}"); Console.WriteLine($"Elapsed time: {elapsed.TotalSeconds} s: Adding {i}");